Update C implementations for Verlet algorithms #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
requested changes
Jul 24, 2018
|
|
||
| while (pos > 0) { | ||
| time += dt; | ||
| (*time) += dt; |
There was a problem hiding this comment.
You don't need the brackets there.
| } | ||
|
|
||
| void stormer_verlet(double pos, double acc, double dt) { | ||
| double prev_pos, temp_pos, time, vel; | ||
| void stormer_verlet(double *time, double *vel, double pos, double acc, double dt) { |
There was a problem hiding this comment.
This line is too long, move the double dt) { part on a new line.
| double time, vel; | ||
| vel = 0; | ||
| time = 0; | ||
| void velocity_verlet(double *time, double *vel, double pos, double acc, double dt) { |
There was a problem hiding this comment.
This line is also too long.
| velocity_verlet(5.0, -10, 0.01); | ||
| double time_v; | ||
| double time_sv, vel_sv; | ||
| double time_vv, vel_vv; |
There was a problem hiding this comment.
why not have one time and velocity variable since you set it to zero at the start of every function.
Gathros
added
the
Implementation Edit
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done according to #257.